add full config #144
Merged
add full config #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samoed
commented
Feb 20, 2025
… add_full_config_validation
# Conflicts: # docs/optimizer_config.schema.json
Member
Author
|
Локально тесты проходят, почему ломаются не понимаю |
Member
Author
|
Возможно можно убрать просто кониг searchspace и использовать один этот |
voorhs
requested changes
Feb 24, 2025
Comment on lines
+184
to
+199
| class TaskConfig(BaseModel): | ||
| """Configuration for the task to optimize.""" | ||
|
|
||
| search_space: OptimizationSearchSpaceConfig | ||
| """Path to the search space configuration file. If None, the default search space will be used""" | ||
| sampler: SamplerType = "brute" | ||
|
|
||
|
|
||
| class OptimizationConfig(BaseModel): | ||
| """Configuration for the optimization process.""" | ||
|
|
||
| data_config: DataConfig = DataConfig() | ||
| task_config: TaskConfig | ||
| logging_config: LoggingConfig = LoggingConfig() | ||
| vector_index_config: VectorIndexConfig = VectorIndexConfig() | ||
| seed: PositiveInt = 42 |
Collaborator
There was a problem hiding this comment.
это конфиги и они должны быть в autointent.configs
Member
Author
There was a problem hiding this comment.
Могу сюда все конфиги тогда перенести
voorhs
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.